Fixed SKZoomingScrollView Initialization
#427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When `SKZoomingScrollView` is initialized, the `setup()` method is called twice: once in `init(frame:)` and then once more in `init(frame:browser:)` * Double call of `setup()` results in UI elements (such as `SKDetectingImageView`) created twice * Even though `SKZoomingScrollView`’s properties (e.g. `imageView`) are reassigned on the second call of `setup()`, the UI elements remain in the view hierarchy and device’s memory * To fix this, `init(frame:browser:)` has been to changed to be a designated initializer, and `init(frame:)` has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKZoomingScrollViewis initialized, thesetup()method is called twice: once ininit(frame:)and then once more ininit(frame:browser:)setup()results in UI elements (such asSKDetectingImageView) created twiceSKZoomingScrollView’s properties (e.g.imageView) are reassigned on the second call ofsetup(), the UI elements remain in the view hierarchy and device’s memoryinit(frame:browser:)has been to changed to be a designated initializer, andinit(frame:)has been removed