Ruby client [2.X] Added inheritance/polymorphism (allOf) to ruby client #11969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjschuetze102
commented
Nov 14, 2022
Comment on lines
+615
to
+621
| @Override | ||
| protected void addImport(CodegenModel m, String type) { | ||
| if (m.parent != null && m.parent.equals(type)) { | ||
| super.addImport(m, type); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Only adds the parent class for importing as the ruby client does not need to know the type of the values it works with, but does need to import the parent class
Comment on lines
+263
to
+267
| @Override | ||
| public String toModelImport(String name) { | ||
| return this.toModelFilename(name); | ||
| } | ||
|
|
There was a problem hiding this comment.
Fixes the import statement to use the file name rather than the model name as that is what Ruby uses to import the additional class
Comment on lines
+39
to
+50
| {{#allVars}} | ||
| :'{{{name}}}' => :'{{{baseName}}}'{{#hasMore}},{{/hasMore}} | ||
| {{/vars}} | ||
| {{/allVars}} | ||
| } | ||
| end | ||
|
|
||
| # Attribute type mapping. | ||
| def self.swagger_types | ||
| { | ||
| {{#vars}} | ||
| {{#allVars}} | ||
| :'{{{name}}}' => :'{{{datatype}}}'{{#hasMore}},{{/hasMore}} | ||
| {{/vars}} | ||
| {{/allVars}} |
There was a problem hiding this comment.
Due to the way the deserializer works in the api_client, the parent values must be present in swagger_types and attribute_map
Comment on lines
+61
to
+65
| {{#parent}} | ||
|
|
||
| # call parent's initialize | ||
| super(attributes) | ||
| {{/parent}} |
There was a problem hiding this comment.
The parent constructor is called with the values passed in to the constructor of the child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This takes some of the changes made to OpenAPI v3.0 and expands on them to add inheritance/ polymorphism to Swagger 2.0