ruby http client integration to use httpx instead of typhoeus #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[httpx](https://honeyryderchuck.gitlab.io/httpx/) is a modern ruby HTTP client, which provide most of the features out-of-the-box that an API client requires. `typhoeus` hasn't seen a release in 3 years, and sees very little activity lately, swagger-codegen should consider moving away from it.
|
@zlx ping |
|
@HugoMario who can I get to review this PR? (apologies for the direct link, but saw you had recently updates, and could have the best chance of getting an answer from). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR proposes switching the HTTP library used by API clients generated for ruby.
httpx is a modern ruby HTTP client, which provides most of the features out-of-the-box that an API client requires.
typhoeushasn't seen a release in 3 years, and sees little activity lately. It's also known for a huge number of issues reported due to compilation/linking tocurl.httpxbeing pure ruby, supporting HTTP/2 and concurrent requests, it supports the same and then some features oftyphoeuswhile being easier to install (no native extensions required).This switch is made conservatively, by "switching the engine" while keeping the same public API as before.