Fix issue #12071. #12072
Open
Fix issue #12071. #12072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the DefaultGenerator class so that the private method generateApis() runs partialy regardless of whether or not we are generating APIs. The part that always runs computes API data that is used by some supporting files templates. This affects the the Go client target among others. Allow supporting files that refer to the API to be generated properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the DefaultGenerator class so that the private method generateApis() runs partialy regardless of whether or not we are generating APIs. The part that always runs computes API data that is used by some supporting files templates.
This affects the the Go client target among others.
Allow supporting files that refer to the API to be generated properly.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
I allowed the loop that processes all the input files to run, but now each iteration terminates early if
!generateApis. This allows all the input data to be accumulated correctly.