Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating uncompilable response body in Spring's API template (2023) #12136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

smasset
Copy link

@smasset smasset commented May 2, 2023

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Creating new PR as suggested in #8691

If definitions start to get complicated, example response bodies can exceed Java compiler's limit for constant strings.

This PR addresses this issue by introducing and using two new lambdas to remove any unnecessary whitespace and (if still needed) to split the constant string into smaller compilable parts using a StringBuilder to merge them back again.

Fixes #9055.

@smasset smasset changed the title Long example string 2023 Avoid generating uncompilable response body in Spring's API template (2023) May 2, 2023
@diyfr
Copy link
Contributor

diyfr commented May 2, 2023

@smasset I am not a maintainer so I cannot validate any PR.
See with https://github.com/orgs/swagger-api/people

@frantuma @HugoMario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JAVA SPRING] error: constant string too long
2 participants