make some module Java 11 friendly - where package javax.xml.bind was remove #12139
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some modules Java 11 friendly.
Since Java 17 is LTS, it's quite common for folks to have 11 or 17 as their main while still working on Java 8 interchangeably. Most of the cases it should be compatible, except for a few. Like in these modules where javax.xml.bind... is required. While one could switch versions back to 8 to perform the build, it'd be nice to not have to.
Explicitly declare com.sun.xml.bind:jaxb-api would make it work for both Java 8 and 11+. This is also consistent with what we already have in https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-generator/pom.xml.jenkins#L264