Allows replacing of the schema serializer #4018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frantuma, @webron and @HugoMario,
Thought its best to simplify this message. My PR here is limited to only providing extensibility to SchemaSerializer so that it can be replaced by any class that extends it by developers who want to do so.
In case there is a better approach to meet the objective of this PR pls suggest. I think it’s a very simple solution to my goal of extending and replacing SchemaSerializer .
Otherwise I hope you liked this PR and will please approve it.
Thank you.
Raghu
PS: Not directly related but I have used this PR’s concept in solving #3312. I can also think of at least one more small problem mainly my last PR I closed myself #3539 I could solve if this extensibility is permitted. (I do understand its debatable whether any other tags should be allowed when using ref but still)