fix: stops reprocessing parameters extracted from nested BeanParam #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormelo95
changed the title
|
@frantuma @HugoMario hey guys can check this? |
vitormelo95
force-pushed
the
fix/nested-bean-parameter
branch
from
6f9f11e
to
86c64de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4334 #3973
As described by the above issues, when using a nested @BeanParam, the defined parameters are shown as the bean type through the schema ref. This is not the expected behavior as we should see the schema of the inner parameters.
Debugging the
DefaultParameterExtensionwe discovered that this is caused by applying the parent field annotations in the extracted parameters. The solution was remove this reprocessing part as we couldn't find a situation where this is necessary.