Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put string as a placeholder instead of value #8215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pompette
Copy link
Contributor

@Pompette Pompette commented Oct 1, 2022

Description

Instead of filling the input with a value that equals to "string", it's now indicated as a placeholder.

Motivation and Context

Fixes #8195

How Has This Been Tested?

Manually testing.
e2e testing.

Screenshots (if appropriate):

Capture d’écran 2022-10-01 à 23 32 37

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • [ x] Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • [ x] are not breaking changes.

Documentation

  • [ x] My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • [ x] My changes can and should be tested by unit and/or integration tests.
  • [x ] If yes to above: I have added tests to cover my changes.
  • [x ] If yes to above: I have taken care to cover edge cases in my tests.
  • [x ] All new and existing tests passed.

Copy link
Contributor

@tim-lai tim-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pompette Thanks for the PR! This proposed change also removes the auto-population of a generated sample schema even when it is "real" and intended.

I think a more accurate fix would be to check if the value of sampleSchema is "real", e.g. not string, then addItem or description as appropriate.

@tim-lai tim-lai self-assigned this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'string' text for string parameters
2 participants