Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for versioned wlroots files #8070

Merged
merged 1 commit into from
May 28, 2024

Conversation

vimproved
Copy link
Contributor

@bl4ckb0ne
Copy link
Contributor

Does this handles using wlroots as a subproject? sway's master branch tracks wlroots master, we use a tagged version for releases.

@emersion
Copy link
Member

Maybe we need to add fallback: 'wlroots'?

@vimproved vimproved force-pushed the wlroots-versioned branch 3 times, most recently from ec1d0b5 to c3646f4 Compare May 27, 2024 22:20
@vimproved vimproved marked this pull request as ready for review May 27, 2024 22:21
@emersion
Copy link
Member

Can we add the fallback? Otherwise this PR breaks subprojects.

@emersion
Copy link
Member

I would prefer not to specify the fallback as an array, because this punches into the subproject's internal variables.

See https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4698

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion merged commit 2e9139d into swaywm:master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants