Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update d3 dependencies #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kr0san89
Copy link
Contributor

@Kr0san89 Kr0san89 commented Jul 5, 2023

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#500
#496
#495

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
no IE, min node v12, maybe other

Other information:
Hard to test would recommend publishing it as some unstable version, so that people can try it

@krishna217
Copy link

@steveblue can you help ?

@Kr0san89
Copy link
Contributor Author

@marjan-georgiev can you have a check?

@Kr0san89
Copy link
Contributor Author

Kr0san89 commented Sep 5, 2023

@jogaj @marjan-georgiev @steveblue can anybody check the PR. I think some people are needing it

@labeled
Copy link

labeled commented Oct 10, 2023

Any status update on this, we're upgrading our Angular version and this is the only thing causing us to use legacy peer deps. And legacy peer deps creates a completely different package-lock.json. It seems a shame this PR has been open for ~3 months with no status updates.

Using 3.0 gives us this error

vendor.d5a14547d33d9b07.js:40 ERROR TypeError: Xu(...).select(...).attr(...).transition is not a function
    at vendor.d5a14547d33d9b07.js:98:1329288
    at Array.map (<anonymous>)
    at I5.map (vendor.d5a14547d33d9b07.js:40:100069)
    at y.redrawLines (vendor.d5a14547d33d9b07.js:98:1329152)
    at vendor.d5a14547d33d9b07.js:98:1326675
    at R.<computed> (polyfills.2d9350f0dc248b2e.js:18:28043)
    at P.invokeTask (polyfills.2d9350f0dc248b2e.js:18:7082)
    at Object.onInvokeTask (vendor.d5a14547d33d9b07.js:40:49942)
    at P.invokeTask (polyfills.2d9350f0dc248b2e.js:18:7003)
    at E.runTask (polyfills.2d9350f0dc248b2e.js:18:2444)

Pointing at this section of code.
image

You can even see the issue using npm list d3-selection
└─┬ @swimlane/ngx-graph@8.2.2
├── d3-selection@1.4.2
├─┬ d3-transition@3.0.1
│ └── d3-selection@3.0.0
└─┬ webcola@3.4.0
└─┬ d3-drag@1.2.5
└── d3-selection@1.4.2

@lazaro3487
Copy link

Is there any update for this PR? It would be nice to be merged.

@Kr0san89
Copy link
Contributor Author

if you need it for security reasons you can try this package: https://www.npmjs.com/package/@kr0san89/ngx-graph/v/9.0.0-next-1

@jaykumarc
Copy link

Can someone please approve and merge this request please ? We are actually blocked by this. Thanks !

@jaykumarc
Copy link

Very humble request to @jogaj @marjan-georgiev @steveblue to kindly review and merge @Kr0san89 's PR. We need to push the application to production and it will be nice to have this solution applied rather than applying workarounds for the issue. Thank you !

@steveblue
Copy link
Contributor

steveblue commented May 23, 2024

Thank you for the contribution and apologies for the difficulty this has caused.

@swimlane/ngx-graph is now on 2.3.0. Can you please sync with master to reflect this change in the package.json?

@jaykumarc
Copy link

jaykumarc commented May 24, 2024

Thank you so @steveblue for your attention. @Kr0san89 Kindly requesting you to please sync your branch with master, so that Stephen can merge it.
Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants