feat: add ng-content at the end of the svg to allow users to add custom svg elements over the nodes. #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om svg elements over the nodes. As SVG Renders in Order as provided in the DOM with the current approach we can only add elements in the background but this ng-content allows with the class "end-content" to brings them into the foreground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As SVG Renders in Order as provided in the DOM with the current approach we can only add elements in the background but this ng-content allows with the class "end-content" to brings them into the foreground
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Custom SVG Elements only in Background
What is the new behavior?
Custom SVG Elements in Background and Foreground
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
If someone used already the css class "end-content" the svg elements would go into foreground, but i guess this is unlikely
Other information: