Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add angular 17 to dependencies #532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kr0san89
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Angular 17 not allowed

What is the new behavior?
Allow Angular 17

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Kr0san89 Kr0san89 mentioned this pull request Dec 15, 2023
Copy link

@SnadgeDirkArendt SnadgeDirkArendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@Malwinderkaur
Copy link

@marjan-georgiev could we please get release for this PR. Currently the library is not working with Angular 17

@Malwinderkaur
Copy link

@marjan-georgiev change is still not available in latest release, its not working with Angular 17

@vbenavides
Copy link

It's not working with Angular 17, release this PR pls.

@Kr0san89
Copy link
Contributor Author

as nobobdy is responding anymore i created a package for ng17 here https://www.npmjs.com/package/@kr0san89/ngx-graph
With the bad effect that when you use it you have to change your imports.

sorry that the readme and so on is still wrong, but i didn't want to invest to much time and i still hope that they will merge contributions from the community again :) or let ppl from the community help with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants