fix - rclone upgrade, and added function #865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format
brettpetch
requested changes
May 18, 2022
| #!/bin/bash | ||
|
|
||
| # Install fuse | ||
| function _fuse() { |
There was a problem hiding this comment.
This really doesn’t need to be its own function. It only needs to run on install.
| fi | ||
|
|
||
| _restart_rclone() { | ||
| systemctl try-restart "rclone@" |
There was a problem hiding this comment.
try-restart rclone@ won’t work. You need to loop through the users.
| #shellcheck source=sources/functions/utils | ||
| . /etc/swizzin/sources/functions/utils | ||
| #shellcheck source=sources/functions/rclone | ||
| . /etc/swizzin/sources/functions/rclone |
There was a problem hiding this comment.
Users are never defined if you’re going to be looping through them to restart the services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues:
Proposed Changes:
Change Categories
Checklist
developbranch and the PR is targetting thedevelopbranchTest scenarios
Architectures
amd64armhfarm64✅❎ Passed
🛠🛠 TODO
❌❌ Currently failing