fix: ya pack --upgrade not being able to upgrade existing packages #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the following packages, running the `ya pack --upgrade` command
results in a prompt for a username:
```sh
❯ cat ~/dotfiles/.config/yazi/package.toml
[plugin]
deps = [{ use = "DreamMaoMao/keyjump.yazi", commit = "06383de" }, { use = "Rolv-Apneseth/starship.yazi", commit = "6197e4c" }]
[flavor]
deps = []
❯ ya pack --upgrade
Upgrading package `keyjump.yazi.yazi`
Cloning into '/Users/mikavilpas/.local/state/yazi/packages/109b2bd4c6591dcb62b40b25202be168'...
Username for 'https://github.com':
```
The problem seems to be that the plugin `DreamMaoMao/keyjump.yazi` is
being resolved to `https://github.com/DreamMaoMao/keyjump.yazi.yazi`
with an extra `.yazi` at the end.
We discussed this behaviour (and decided it's preferred to add `.yazi`
when adding new packages) in
- sxyazi#1019
- sxyazi#1023
...but I did not realize at the time that it also affects upgrading
packages.
|
Hi, no |
|
Oh, I see. It must have been the case that my configuration is actually wrong! In that case I agree, this should be closed as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following packages, running the
ya pack --upgradecommand results in a prompt for a username:The problem seems to be that the plugin
DreamMaoMao/keyjump.yaziis being resolved tohttps://github.com/DreamMaoMao/keyjump.yazi.yaziwith an extra.yaziat the end.We discussed this behaviour (and decided it's preferred to add
.yaziwhen adding new packages) inya packsupports yazi packages that end in.yazi#1019...but I did not realize at the time that it also affects upgrading packages.