[Serializer] Fixed "Warning: Attempt to read property "value" on string"

[michaljusiega]

Q	A
Branch?	7.1 (7.1.0-BETA1)
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fixed regresion of #53160
License	MIT

Hi! I've updated my project to 7.1.0-BETA1 and I found an error.

After update I got: Warning: Attempt to read property "value" on string in vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748 because in 733 line the enum-case of value TypeIdentifier has been already readed.

Quite not sure if tests are possible here.

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1.0-BETA1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[xabbuh]

Can we cover this change with a test to prevent future regressions?

[michaljusiega]

Can we cover this change with a test to prevent future regressions?

I'll try tomorrow.

[michaljusiega]

This is a reproduce code at the moment:

class AbstractObjectNormalizerTest extends KernelTestCase
{
    public function testDenormalizeNestedValues()
    {
        $normalizer = self::getContainer()->get(NormalizerInterface::class); // service
        $normalizer->denormalize(['values' => [['1'], ['2'], ['3'], ['4'], ['5']]], TypeClassReproducer::class);
    }
}

class TypeClassReproducer
{
    /**
     * @param array<int, array<int, string>>|null $values
     */
    public function __construct(
        private readonly array|null $values = null,
    ) {
    }
    /** @return array<int, array<int, string>>|null */
    public function getValues(): array|null
    {
        return $this->values;
    }
}

[michaljusiega]

@xabbuh I gave up. Could you help me ?

[xabbuh]

thanks for the snippet, I was able to create a test based on it 👍

[xabbuh]

Thank you @michaljusiega.

[michaljusiega]

Thank you too @xabbuh !