-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stopwatch] Add ROOT
constant to make it easier to reference
#54854
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
ROOT
constant to make it easier to reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 7.2
What about if we also add a method named |
@xabbuh Updated as requested. |
Thank you @hacfi. |
Just an DX improvement so you can reference the root section with
$stopwatch->getSectionEvents(Stopwatch::ROOT)
instead of$stopwatch->getSectionEvents('__root__')
.