PHP 8.4 nullability deprecation

[sam-bee]

PHP 8.4 deprecation of implicit nullability.

Q	A
Branch?	7.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Because PHP 8.4 is adding deprecation warnings for non-nullable parameters with null default, change typehints.

This relates to the implicit nullability RFC in PHP 8.4.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[antonkomarev]

@sam-bee maybe it's better to define it as |null instead of ?

There is no way to define something like ?string|int, but there is a way to define string|int|null. I think there will be better to stick with only one way of nullability definition style.

[derrabus]

Thank you @sam-bee.