[Serializer] Fix CurrentType for missing property

[ElisDN]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

If requested data does not contain any property:

class A {
    function __construct(string $a) {}
}

try {
    $a = $serializer->deserialize('{}', A::class, 'json');
} catch (NotNormalizableValueException $e) {
    var_dump($e->getMessage());       // "Failed to create object because class misses the 'a' property."
    var_dump($e->getPath());          // "a"
    var_dump($e->getExpectedTypes()); // ["string"]
    var_dump($e->getCurrentType());   // "array"
}

then getCurrentType returns incorrect "array" value instead of expected "null" value.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[xabbuh]

Shouldn't this be $parameterData instead?

[ElisDN]

There is $parameterData = $data[$key] statement in cases above. But in this case (with missing parameter) the $data[$key] value does not exist and $parameterData will be empty too.

[nicolas-grekas]

Thank you @ElisDN.