varlinkctl: when operating in --more mode, fail correcly on Varlink m… #32788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
added
bug 🐛
github-actions
bot
added
the
please-review
bluca
approved these changes
May 13, 2024
bluca
added
good-to-merge/waiting-for-ci 👍
poettering
force-pushed
the
varlinkctl-more-fix
branch
from
f4dd9cb
to
5e65388
Compare
|
force pushed a new version. |
poettering
added
please-review
…ethod error In varlink.c we generally do not make failing callback functions fatal, since that should be up to the app. Hence, in case of varlinkctl (where we want failures to be fatal), make sure to propagate the error back explicitly. Before this change a failing call to "varlinkctl --more call …" would result in a zero exit code. With this it will correctly exit with a non-zero exit code.
poettering
force-pushed
the
varlinkctl-more-fix
branch
from
5e65388
to
b37fdf6
Compare
bluca
approved these changes
May 22, 2024
bluca
added
good-to-merge/waiting-for-ci 👍
yuwata
approved these changes
May 22, 2024
keszybz
approved these changes
May 22, 2024
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ethod error
In varlink.c we generally do not make failing callback functions fatal, since that should be up to the app. Hence, in case of varlinkctl (where we want failures to be fatal), make sure to propagate the error back explicitly.
Before this change a failing call to "varlinkctl --more call …" would result in a zero exit code. With this it will correctly exit with a non-zero exit code.