analyze: add new verb "smbios11" for listing passed smbios type #11 strings #32810
Conversation
|
Would it make sense to have the tool optionally emit machine parsable output (ie omit the trailing log message)? |
that goes to stderr anyway (unlike the strings themselves) and you can always use SYSTEMD_LOG_TARGET=null... |
github-actions
bot
added
documentation
build-system
util-lib
meson
please-review
|
Right. I didn't pay attention to how the command is implemented, I just inferred from the documentation. Thanks! |
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
poettering
force-pushed
the
smbios11-analyze
branch
from
82d1206
to
12600ef
Compare
|
new version pushed, ptal |
yuwata
added
good-to-merge/after-next-release
good-to-merge/with-minor-suggestions
and removed
please-review
btw, the message is now also suppressed if you add "-q" or "--quiet" to the cmdline |
I find myself wanting to check this data with a quick command, and browsing through /sys/ manually getting binary data sucks. Hence let's do add a nice little analysis tool.
done |
poettering
force-pushed
the
smbios11-analyze
branch
from
12600ef
to
1e6a0c5
Compare
| p, | ||
| max_size >= SIZE_MAX - offsetof(struct dmi_field_header, contents) ? SIZE_MAX : | ||
| sizeof(dmi_field_header) + max_size, | ||
| (char**) &data, &size); |
There was a problem hiding this comment.
Hmm, why not directly read into dmi_field_header?
| uint16_t handle; | ||
| uint8_t count; | ||
| char contents[]; | ||
| } _packed_ *dmi_field_header; |
There was a problem hiding this comment.
i.e.:
| } _packed_ *dmi_field_header; | |
| } _packed_ * _cleanup_free_ dmi_field_header; |
There's no nice way to query this otherwise with default distro tools