shutdown: several cleanups, rename initrd to exitrd #32847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
yuwata
approved these changes
May 15, 2024
yuwata
added
good-to-merge/after-next-release
and removed
please-review
|
@YHNdnzj Do you want this in v256? |
I'm fine with delaying this. It's mostly cosmetic :) |
yuwata
reviewed
May 15, 2024
yuwata
reviewed
May 15, 2024
|
Addressed the comments and added a few more commits, PTAL. |
yuwata
reviewed
May 15, 2024
YHNdnzj
changed the title
yuwata
approved these changes
May 15, 2024
yuwata
added
good-to-merge/after-next-release
and removed
please-review
|
lgtm, too |
Nowadays the tmpfs where the final shutdown phase is initiated has got its own name. Plus, "Returning to initrd" sounds spurious anyway, as we're not returning to the initial root tmpfs as seen by the kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by deaa4fb