Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion between killer and prey #32868

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keszybz
Copy link
Member

@keszybz keszybz commented May 16, 2024

"who" is the entity doing the killing, "whom" is the target. Follow-up for 4ccde41.

"who" is the entity doing the killing, "whom" is the target.
Follow-up for 4ccde41.
@github-actions github-actions bot added login documentation tests please-review PR is ready for (re-)review by a maintainer labels May 16, 2024
Copy link

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

src/login/logind-session.h Outdated Show resolved Hide resolved
src/machine/machine.h Outdated Show resolved Hide resolved
src/core/kill.h Outdated Show resolved Hide resolved
@YHNdnzj YHNdnzj added machine pid1 good-to-merge/with-minor-suggestions and removed please-review PR is ready for (re-)review by a maintainer labels May 16, 2024
@keszybz keszybz added the please-review PR is ready for (re-)review by a maintainer label May 17, 2024
Copy link
Member

@YHNdnzj YHNdnzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yuwata yuwata added this to the v257 milestone May 17, 2024
@poettering
Copy link
Member

lgtm, but needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants