Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable JS build for all architecture #1869

Closed
6 tasks
amitksingh1490 opened this issue May 6, 2024 · 16 comments · Fixed by #1963 or #2032
Closed
6 tasks

fix: Enable JS build for all architecture #1869

amitksingh1490 opened this issue May 6, 2024 · 16 comments · Fixed by #1963 or #2032
Labels
💎 Bounty 💰 Rewarded

Comments

@amitksingh1490
Copy link
Collaborator

amitksingh1490 commented May 6, 2024 •
edited by tusharmath

Issue Description:

We recently migrated from V8 to QuickJS for our JavaScript runtime. We initially utilized feature flags for disabling the build of JS features for architectures where V8 was incompatible.

Now, we aim to enable JS feature across all architectures.

Note: While this may potentially encounter issues on certain architectures, we should iteratively enable it for those where it works.

The expectation is to update the CI to build Tailcall on all supported platforms without any feature flags.

Additional Context:

  • Unsupported platforms

    • linux-x64-musl
    • linux-arm64-musl
    • linux-ia32-gnu
    • win32-x64-gnu
    • win32-arm64-msvc
    • win32-ia32-gnu

  • How it works on CI

    tailcall/.github/workflows/ci.yml

    Line 266 in dd2114d

    features: --no-default-features --features cli

@tusharmath tusharmath changed the title Enable Js build for all architecture feat: Enable JS build for all architecture May 13, 2024
@tusharmath
Copy link
Contributor

/bounty 180$

IMPORTANT: The bounty is priced at 30$ per platform. So in case only two platforms are supported we will pay only 60$.

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 13, 2024 •
edited

## 💎 $180 bounty • Tailcall Inc.

### Steps to solve:
1. Start working: Comment /attempt #1869 with your implementation plan
2. Submit work: Create a pull request including /claim #1869 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.

Attempt Started (GMT+0) Solution
🔴 @feliciien May 13, 2024, 7:52:24 AM WIP
🔴 @ezhil56x May 13, 2024, 8:51:38 AM WIP
🟢 @varshith257 May 14, 2024, 9:16:28 PM #1963
🟢 @mehulmathur16 #1962
🟢 @ssddOnTop #2032

@tusharmath tusharmath changed the title feat: Enable JS build for all architecture fix: Enable JS build for all architecture May 13, 2024
@feliciien
Copy link

feliciien commented May 13, 2024 •
edited by algora-pbc bot

/attempt #186

Algora profile Completed bounties Tech Active attempts Options
@feliciien 5 bounties from 1 project
MDX, Rust,
JavaScript & more
Cancel attempt

@ezhil56x
Copy link
Contributor

ezhil56x commented May 13, 2024 •
edited by algora-pbc bot

/attempt #1869

Algora profile Completed bounties Tech Active attempts Options
@ezhil56x    5 tailcallhq bounties
+ 20 bounties from 9 projects
JavaScript, TypeScript,
Java & more
Cancel attempt

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 13, 2024

Note

The user @feliciien is already attempting to complete issue #1869 and claim the bounty. We recommend checking in on @feliciien's progress, and potentially collaborating, before starting a new solution.

@ezhil56x ezhil56x mentioned this issue May 13, 2024
Closed
6 tasks
This was referenced May 13, 2024
Closed
Closed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 14, 2024

@feliciien: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

@mehulmathur16 mehulmathur16 mentioned this issue May 14, 2024
Merged
@varshith257
Copy link
Contributor

varshith257 commented May 14, 2024 •
edited by algora-pbc bot

/attempt #1869

Options

@varshith257 varshith257 mentioned this issue May 14, 2024
Merged
12 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 14, 2024 •
edited

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@tusharmath tusharmath reopened this May 16, 2024
@tusharmath
Copy link
Contributor

tusharmath commented May 16, 2024 •
edited

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401
https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

@mehulmathur16
Copy link
Contributor

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401
https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

@tusharmath on it

@varshith257
Copy link
Contributor

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401 https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

Taking a look on it

@varshith257
Copy link
Contributor

varshith257 commented May 16, 2024 •
edited

@tusharmath Got the solution for it. Can you provide suggestion on how to test the behaviour of release workflow with changes?

Is release workflow run when packages updates?

It seems the errors occured in release workflow aren't related with this issue. Fixing it

@varshith257
Copy link
Contributor

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401
https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

@tusharmath Can re-run the workflows in above mentioned links? I think it's reverted pr got merged but I suscept feature flag doesn't causing of release build fails. But let's check-in

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 20, 2024

🎉🎈 @mehulmathur16 has been awarded $120! 🎈🎊

@ssddOnTop ssddOnTop mentioned this issue May 27, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 27, 2024

💡 @ssddOnTop submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 29, 2024

🎉🎈 @ssddOnTop has been awarded $180! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty 💰 Rewarded
Projects
None yet
Milestone
No milestone
6 participants
@tusharmath @amitksingh1490 @mehulmathur16 @ezhil56x @feliciien @varshith257