Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable JS build for all architecture #1925

Closed
wants to merge 1 commit into from
Closed

fix: enable JS build for all architecture #1925

wants to merge 1 commit into from

Conversation

ezhil56x
Copy link
Contributor

@ezhil56x ezhil56x commented May 13, 2024 •
edited

Summary:
WIP
Issue Reference(s):
Fixes #1869
/claim #1869

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request May 13, 2024
Open
6 tasks
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 13, 2024
@ezhil56x ezhil56x marked this pull request as draft May 13, 2024 08:56
ssddOnTop
ssddOnTop reviewed May 13, 2024
View reviewed changes
.github/workflows/ci.yml
Comment on lines -249 to -252
win32-x64-msvc,
win32-x64-gnu,
win32-arm64-msvc,
win32-ia32-gnu,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:
Removed unsupported platforms

I think we need to fix the build for JS runtime on all the platforms, and not remove the platforms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should enable support for unsupported platforms. Working on it!

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 15, 2024
@ezhil56x ezhil56x closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssddOnTop ssddOnTop ssddOnTop left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Enable JS build for all architecture
2 participants
@ezhil56x @ssddOnTop