Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): JS based resolvers #1867

Merged
merged 31 commits into from
May 24, 2024
Merged

feat(js): JS based resolvers #1867

merged 31 commits into from
May 24, 2024

Conversation

ssddOnTop
Copy link
Member

No description provided.

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 5, 2024
@codecov Codecov
Copy link

codecov bot commented May 5, 2024 •
edited

Codecov Report

Attention: Patch coverage is 91.60305% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 82.69%. Comparing base (4cca178) to head (8f69141).

Files Patch % Lines
src/cli/javascript/runtime.rs 92.59% 4 Missing ⚠️
src/core/lambda/io.rs 81.81% 2 Missing ⚠️
tailcall-aws-lambda/src/runtime.rs 0.00% 2 Missing ⚠️
tailcall-cloudflare/src/runtime.rs 0.00% 2 Missing ⚠️
src/cli/runtime/mod.rs 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   82.60%   82.69%   +0.09%     
==========================================
  Files         174      175       +1     
  Lines       17930    18022      +92     
==========================================
+ Hits        14811    14904      +93     
+ Misses       3119     3118       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tusharmath
tusharmath reviewed May 7, 2024
View reviewed changes
src/lambda/expression.rs Outdated Show resolved Hide resolved
tusharmath
tusharmath reviewed May 7, 2024
View reviewed changes
src/lambda/js_ctx.rs Outdated Show resolved Hide resolved
tusharmath
tusharmath reviewed May 7, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
tusharmath
tusharmath reviewed May 8, 2024
View reviewed changes
src/lambda/expression.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath changed the title feat(js): ability to filter value with js feat(js): JS based resolvers May 9, 2024
tusharmath
tusharmath reviewed May 9, 2024
View reviewed changes
src/cli/mod.rs Outdated Show resolved Hide resolved
@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label May 22, 2024
tusharmath
tusharmath reviewed May 23, 2024
View reviewed changes
src/core/mod.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 23, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 23, 2024 14:05
@ssddOnTop ssddOnTop mentioned this pull request May 23, 2024
Open
@tusharmath tusharmath mentioned this pull request May 24, 2024
Open
@ssddOnTop ssddOnTop disabled auto-merge May 24, 2024 12:59
@ssddOnTop ssddOnTop enabled auto-merge (squash) May 24, 2024 13:05
@ssddOnTop ssddOnTop disabled auto-merge May 24, 2024 13:07
@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label May 24, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 24, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 24, 2024 14:52
@tusharmath tusharmath merged commit 72c87ed into main May 24, 2024
32 checks passed
@tusharmath tusharmath deleted the feat/js-filter branch May 24, 2024 14:53
@tusharmath
Copy link
Contributor

tusharmath commented May 24, 2024 •
edited

/tip 300$

Thanks!

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 24, 2024

🎉🎈 @ssddOnTop has been awarded $300! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitksingh1490 amitksingh1490 amitksingh1490 left review comments

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
ci: benchmark Runs benchmarks 💰 Rewarded type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssddOnTop @tusharmath @amitksingh1490