chore: removing Clone derivation from Blueprint
#1871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
==========================================
- Coverage 89.73% 89.71% -0.03%
==========================================
Files 154 155 +1
Lines 15817 15871 +54
==========================================
+ Hits 14193 14238 +45
- Misses 1624 1633 +9 ☔ View full report in Codecov by Sentry. |
tusharmath
reviewed
May 6, 2024
src/blueprint/blueprint.rs
Outdated
| pub schema: Arc<SchemaDefinition>, | ||
| pub server: Arc<Server>, | ||
| pub upstream: Arc<Upstream>, | ||
| pub telemetry: Arc<Telemetry>, |
There was a problem hiding this comment.
blueprint can't have internal mutable states. So no Arc.
|
| Report | Fri, May 10, 2024 at 10:04:56 UTC |
| Project | tailcall |
| Branch | 1871/merge |
| Testbed | benchmarking-runner |
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/vars.existing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 23.56 (+179.53%) | 11.42 (206.38%) | |
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 29.51 (+255.87%) | 12.45 (237.14%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 611.63 (+0.70%) | 632.55 (96.69%) |
| input/args.missing | ✅ (view plot) | 23.12 (-7.97%) | 26.91 (85.91%) |
| input/args.nested.existing | ✅ (view plot) | 41.24 (-24.16%) | 64.96 (63.49%) |
| input/args.nested.missing | ✅ (view plot) | 37.75 (-2.67%) | 40.64 (92.91%) |
| input/args.root | ✅ (view plot) | 37.74 (-26.02%) | 61.12 (61.75%) |
| input/headers.existing | ✅ (view plot) | 31.61 (-0.30%) | 32.97 (95.86%) |
| input/headers.missing | ✅ (view plot) | 30.41 (-0.62%) | 32.42 (93.78%) |
| input/value.missing | ✅ (view plot) | 23.35 (-0.81%) | 25.03 (93.31%) |
| input/value.nested.existing | ✅ (view plot) | 41.28 (-0.10%) | 43.14 (95.70%) |
| input/value.nested.missing | ✅ (view plot) | 37.22 (+2.74%) | 38.12 (97.65%) |
| input/value.root | ✅ (view plot) | 37.79 (-2.28%) | 39.93 (94.63%) |
| input/vars.existing | 🚨 (view plot | view alert) | 23.56 (+179.53%) | 11.42 (206.38%) |
| input/vars.missing | 🚨 (view plot | view alert) | 29.51 (+255.87%) | 12.45 (237.14%) |
| test_batched_body | ✅ (view plot) | 2,631.80 (-99.75%) | 2,811,147.56 (0.09%) |
| test_batched_body #2 | ✅ (view plot) | 1,749,300.00 (-1.37%) | 1,899,472.31 (92.09%) |
| test_data_loader | ✅ (view plot) | 474,670.00 (+0.23%) | 490,652.15 (96.74%) |
| test_handle_request | ✅ (view plot) | 167,410.00 (-3.30%) | 184,655.53 (90.66%) |
| with_mustache_expressions | ✅ (view plot) | 1,151.60 (-1.87%) | 1,236.82 (93.11%) |
| with_mustache_literal | ✅ (view plot) | 726.11 (+0.46%) | 764.83 (94.94%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
@tusharmath |
shashitnak
changed the title
Arc to optimize cloning of BlueprintClone derivation from Blueprint
shashitnak
changed the title
Clone derivation from BlueprintClone derivation from Blueprint
github-actions
bot
added
the
type: chore
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
github-actions
bot
removed
the
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 5 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Using
Arcto optimize cloning ofBlueprintIssue Reference(s):
Fixes #1858
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>