Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @validate directive for custom scalars #1889

Closed
wants to merge 7 commits into from

Conversation

mobley-trent
Copy link
Contributor

Summary:
Adds the @validate directive for custom scalars. Currently, there is no mechanism to validate custom scalars as opposed to the other types in Tailcall.

Issue Reference(s):
/claim #1847
closes #1847

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 7, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@756a56f). Learn more about missing BASE report.
Report is 44 commits behind head on main.

Current head dcb32d9 differs from pull request most recent head a8ec8a1

Please upload reports for the commit a8ec8a1 to get more accurate results.

Files Patch % Lines
src/config/config.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage        ?   89.70%           
=======================================
  Files           ?      154           
  Lines           ?    15849           
  Branches        ?        0           
=======================================
  Hits            ?    14217           
  Misses          ?     1632           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 12, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 13, 2024
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add @validate directive for custom scalar validation
1 participant