Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc): type and field names for config from protobuf generation #1895

Merged
merged 24 commits into from
May 16, 2024
Merged

fix(grpc): type and field names for config from protobuf generation #1895

merged 24 commits into from
May 16, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented May 8, 2024 •
edited

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1754, fixes #1899, fixes #1897, fixes #1898

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited

Codecov Report

Attention: Patch coverage is 97.10983% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.06%. Comparing base (390b5a4) to head (74cdff5).

Files Patch % Lines
src/core/json/json_schema.rs 86.95% 9 Missing ⚠️
src/core/generator/from_proto.rs 99.04% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   82.02%   82.06%   +0.04%     
==========================================
  Files         173      173              
  Lines       17531    17608      +77     
==========================================
+ Hits        14379    14450      +71     
- Misses       3152     3158       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 13, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 13, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 15, 2024
@meskill meskill mentioned this pull request May 16, 2024
Closed
@tusharmath tusharmath enabled auto-merge (squash) May 16, 2024 10:53
@tusharmath tusharmath merged commit 4f033c9 into main May 16, 2024
38 checks passed
@tusharmath tusharmath deleted the fix/grpc-generation branch May 16, 2024 13:12
TheWizardTower pushed a commit to TheWizardTower/tailcall that referenced this pull request May 16, 2024
@meskill @tusharmath
@renovate @TheWizardTower
fix(grpc): type and field names for config from protobuf generation (t…
8b0d8d5 
…ailcallhq#1895)

Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
Generate GraphQL config from protobuf...
2 participants
@meskill @tusharmath