-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use custom HTTP Cache #1910
Conversation
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Action required: PR inactive for 2 days. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
+ Coverage 82.08% 82.16% +0.08%
==========================================
Files 173 174 +1
Lines 17623 17716 +93
==========================================
+ Hits 14465 14556 +91
- Misses 3158 3160 +2 ☔ View full report in Codecov by Sentry. |
- use MokaCache from http_cache_reqwest
Action required: PR inactive for 2 days. |
Summary:
PR contains a benchmark for execute method present in
http.rs
.currently the benchmark only tests execute method with http_cache set to true.
bench results:
before:
[38.054 µs 38.204 µs 38.428 µs]
[27.049 µs 27.363 µs 27.774 µs]
[26.795 µs 27.089 µs 27.492 µs]
after:
[18.419 µs 18.432 µs 18.449 µs]
[17.414 µs 17.743 µs 18.018 µs]
[14.797 µs 14.876 µs 14.975 µs]
performance improvement : 51%.
Issue Reference(s):
related to #1852
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>