-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replacing HeaderMap::new
with HeaderMap::with_capacity
#1923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## perf/base #1923 +/- ##
=============================================
- Coverage 89.73% 89.73% -0.01%
=============================================
Files 155 155
Lines 15837 15832 -5
=============================================
- Hits 14212 14207 -5
Misses 1625 1625 ☔ View full report in Codecov by Sentry. |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
HeaderMap::new
with HeaderMap::with_capacity
HeaderMap::new
with HeaderMap::with_capacity
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: amit <amitksingh1490@gmail.com>
Action required: PR inactive for 2 days. |
Action required: PR inactive for 2 days. |
Summary:
Following improvements were observed when running the nginx benchmark locally
Before the change:
After the change:
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>