Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Automatically Resolve Ambiguous Types in Configuration #1924

Closed
wants to merge 6 commits into from

Conversation

ssddOnTop
Copy link
Member

Sample command:
cargo run -- gen tailcall-fixtures/fixtures/generator/proto/news.proto -i proto -o gql -r 'prefix=IPrefix_ suffix=_ISuffix'

Issue Reference(s):
Fixes #1870
/claim 1870

TODO:

  • The Tailcall CLI no longer throws errors when the same type is used in both the input and output sections of the configuration.
  • Ambiguous type are automatically detected and resolved using the resolve_ambiguous_types function.
  • Integration test for this using execution_spec should be added.

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (186fd6b) to head (1e27921).
Report is 30 commits behind head on main.

Files Patch % Lines
src/cli/tc.rs 83.69% 15 Missing ⚠️
src/core/generator/generator.rs 82.35% 3 Missing ⚠️
src/core/config/config_module.rs 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1924      +/-   ##
==========================================
+ Coverage   89.73%   90.12%   +0.38%     
==========================================
  Files         155      155              
  Lines       15837    15929      +92     
==========================================
+ Hits        14212    14356     +144     
+ Misses       1625     1573      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssddOnTop ssddOnTop marked this pull request as ready for review May 13, 2024 17:26
@ssddOnTop ssddOnTop marked this pull request as draft May 14, 2024 08:02
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 16, 2024
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 18, 2024
Copy link

PR closed after 5 days of inactivity.

@github-actions github-actions bot closed this May 23, 2024
@ssddOnTop ssddOnTop reopened this May 23, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 23, 2024
@ssddOnTop ssddOnTop closed this May 25, 2024
@ssddOnTop ssddOnTop deleted the chore/resolve-ambiguous-types-cli branch May 25, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Ambiguous Types in Configuration Automatically
1 participant