perf: creating HeaderMap from iterator
#1938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: amit <amitksingh1490@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## perf/base #1938 +/- ##
==========================================
Coverage 89.73% 89.74%
==========================================
Files 155 155
Lines 15837 15842 +5
==========================================
+ Hits 14212 14217 +5
Misses 1625 1625 ☔ View full report in Codecov by Sentry. |
|
| Report | Mon, May 13, 2024 at 16:56:41 UTC |
| Project | tailcall |
| Branch | 1938/merge |
| Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 11.55 (+41.07%) | 9.52 (121.32%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 548.07 (-9.52%) | 638.10 (85.89%) |
| input/args.missing | ✅ (view plot) | 22.80 (-8.76%) | 27.16 (83.94%) |
| input/args.nested.existing | ✅ (view plot) | 41.83 (-21.70%) | 65.70 (63.67%) |
| input/args.nested.missing | ✅ (view plot) | 38.15 (-1.33%) | 40.71 (93.71%) |
| input/args.root | ✅ (view plot) | 38.19 (-23.71%) | 61.91 (61.69%) |
| input/headers.existing | ✅ (view plot) | 33.01 (+3.83%) | 33.36 (98.97%) |
| input/headers.missing | ✅ (view plot) | 31.57 (+2.81%) | 32.83 (96.19%) |
| input/value.missing | ✅ (view plot) | 23.48 (-0.34%) | 25.28 (92.92%) |
| input/value.nested.existing | ✅ (view plot) | 41.94 (+1.27%) | 43.58 (96.24%) |
| input/value.nested.missing | ✅ (view plot) | 37.09 (+2.13%) | 38.24 (97.00%) |
| input/value.root | ✅ (view plot) | 37.81 (-2.15%) | 40.02 (94.49%) |
| input/vars.existing | ✅ (view plot) | 7.43 (-9.94%) | 9.02 (82.42%) |
| input/vars.missing | 🚨 (view plot | view alert) | 11.55 (+41.07%) | 9.52 (121.32%) |
| test_batched_body | ✅ (view plot) | 2,630.90 (-99.73%) | 2,757,085.92 (0.10%) |
| test_batched_body #2 | ✅ (view plot) | 1,709,200.00 (-2.91%) | 1,891,165.02 (90.38%) |
| test_data_loader | ✅ (view plot) | 475,530.00 (+0.43%) | 490,400.93 (96.97%) |
| test_handle_request | ✅ (view plot) | 168,690.00 (-2.14%) | 181,997.06 (92.69%) |
| with_mustache_expressions | ✅ (view plot) | 1,115.50 (-4.96%) | 1,238.14 (90.09%) |
| with_mustache_literal | ✅ (view plot) | 141.43 (-80.33%) | 833.32 (16.97%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
No improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>