fix: allow default values for input arguments #1939
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
github-actions
bot
added
the
type: fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
+ Coverage 82.08% 82.10% +0.02%
==========================================
Files 173 173
Lines 17623 17644 +21
==========================================
+ Hits 14465 14486 +21
Misses 3158 3158 ☔ View full report in Codecov by Sentry. |
|
| Report | Sat, May 18, 2024 at 03:45:12 UTC |
| Project | tailcall |
| Branch | 1939/merge |
| Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 11.73 (+37.26%) | 10.95 (107.14%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | ✅ (view plot) | 535.10 (-10.68%) | 648.29 (82.54%) |
| input/args.missing | ✅ (view plot) | 22.93 (-7.37%) | 27.22 (84.23%) |
| input/args.nested.existing | ✅ (view plot) | 42.66 (-18.05%) | 65.96 (64.67%) |
| input/args.nested.missing | ✅ (view plot) | 37.38 (-3.00%) | 40.63 (92.01%) |
| input/args.root | ✅ (view plot) | 37.92 (-21.97%) | 62.51 (60.67%) |
| input/headers.existing | ✅ (view plot) | 33.03 (+3.91%) | 33.50 (98.61%) |
| input/headers.missing | ✅ (view plot) | 31.55 (+2.47%) | 33.37 (94.52%) |
| input/value.missing | ✅ (view plot) | 23.19 (-1.54%) | 25.36 (91.41%) |
| input/value.nested.existing | ✅ (view plot) | 42.07 (+1.40%) | 43.95 (95.72%) |
| input/value.nested.missing | ✅ (view plot) | 36.84 (+1.19%) | 38.34 (96.09%) |
| input/value.root | ✅ (view plot) | 37.57 (-2.40%) | 40.38 (93.04%) |
| input/vars.existing | ✅ (view plot) | 7.44 (-8.94%) | 9.06 (82.05%) |
| input/vars.missing | 🚨 (view plot | view alert) | 11.73 (+37.26%) | 10.95 (107.14%) |
| test_batched_body | ✅ (view plot) | 2,682.70 (-99.69%) | 2,654,750.22 (0.10%) |
| test_batched_body #2 | ✅ (view plot) | 1,634,100.00 (-6.06%) | 1,888,131.04 (86.55%) |
| test_data_loader | ✅ (view plot) | 460,710.00 (-2.46%) | 490,377.11 (93.95%) |
| test_handle_request | ✅ (view plot) | 157,400.00 (-7.82%) | 182,978.09 (86.02%) |
| with_mustache_expressions | ✅ (view plot) | 1,183.80 (+1.04%) | 1,236.24 (95.76%) |
| with_mustache_literal | ✅ (view plot) | 741.64 (+2.43%) | 772.57 (96.00%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
tusharmath
reviewed
May 15, 2024
src/core/blueprint/into_schema.rs
Outdated
| } else { | ||
| async_graphql_value::to_value(args).unwrap_or_default() | ||
| }; | ||
|
|
||
| let mut dyn_schema_field = dynamic::Field::new( |
There was a problem hiding this comment.
Just call the the dyn_schema_field.arguments(args) Current implementation is a bit complicated and unnecessary.
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
ssddOnTop
removed
the
state: inactive
This reverts commit fd6f875.
|
there is an issue with async-graphql as well, I raised a PR async-graphql/async-graphql#1527 there if it gets merged, I'll finish touchups in this PR. |
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
state: inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference(s):
Fixes #1931
/claim 1931