Secure websockets #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takielias
reviewed
May 30, 2020
| @@ -131,28 +131,29 @@ public function __construct(array $config = array()) | |||
| public function run() | |||
| { | |||
| // Initiliaze all the necessary class | |||
| $server = IoServer::factory( | |||
There was a problem hiding this comment.
Please don't remove the previous Timer.
takielias
reviewed
May 30, 2020
|
|
||
| $secure_websockets = new \React\Socket\Server($this->host . ':' . $this->port, $loop); | ||
| $secure_websockets = new \React\Socket\SecureServer($secure_websockets, $loop, [ | ||
| 'local_cert' => '/path/to/server.crt', |
There was a problem hiding this comment.
local_cert
local_pk
allow_self_signed
verify_peer
The above parameters should not be hardcoded. Please use the codeigniter_websocket.php config file to maintain the value.
takielias
requested changes
May 30, 2020
iftikhar786
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Taki,
added code for secure web sockets.