Adding logging and refactoring repositories and operations #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added logging capabilities based on operations.
logging in the operation means adding steps and their description. this can be done via predefined methods that take a description and extra data. the logs are stored to file on error only and are marked by a request ID that is injected. on a success, the trace id deleted forever.
added refactoring for the operations (logging methods) and the repositories.
create a base repository for sequelize with the most common methods predefined. extending the base repository and injecting the sequelize model in the super constructor as well as the mapper is a mandatory step.
this only allows for one model and one mapper.
Changed readme to include logging mechanism description.