SW-SPI over Patch Method. #1291
Conversation
|
Besteht überhaupt ein Interesse an der ePaper Integration in OpenDTU @tbnobody ? |
|
Yes, we are waiting for it ! |
|
What is the current status of the merge? |
There was a problem hiding this comment.
Due to lack of details of the inner parts of the project I cannot judge the split of the split into two different display classes. Besides removing -Werror the rest of the change looks good to me.
@tbnobody It'd be great if you could have a look as well. This is a really great addition to the project.
| GxEPD2_GFX* _display; | ||
| }; | ||
|
|
||
| extern DisplayEPaperClass DisplayEPaper; |
There was a problem hiding this comment.
I cannot tell whether or not memory is limited. If memory is limited the different display classes could go into a union and get initialized with a placement new.
| @@ -24,11 +24,17 @@ platform = espressif32@6.3.2 | |||
| build_flags = | |||
| -DCOMPONENT_EMBED_FILES=webapp_dist/index.html.gz:webapp_dist/zones.json.gz:webapp_dist/favicon.ico:webapp_dist/favicon.png:webapp_dist/js/app.js.gz | |||
| -DPIOENV=\"$PIOENV\" | |||
| -Wall -Wextra -Werror | |||
| -Wall -Wextra ;-Werror | |||
There was a problem hiding this comment.
Which part of the change generate warnings? Those should be fixed instead of just disabling warnings as errors to keep compile output readable.
|
@3PrintD-Solution @dAjaY85 This PR is superseeeded by #1703 with the changes applied to master a and a few issues fixed. |
This is the SW-SPI Version, with the ahoy patch method, modified for OpenDTU!