Add docs describing retry behavior #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
retry-docs
branch
2 times, most recently
from
29d8b57
to
c70020a
Compare
stephanos
commented
May 8, 2024
dnr
reviewed
May 8, 2024
|
@dnr I re-structured the document and added client-side retry, too. It's not very detailed - partially because I don't know any more, and partially because I don't want to over-describe the code to prevent staleness later. But if there are more high-level ideas/concepts that would be useful here, I'd be happy to add them. |
dnr
approved these changes
May 14, 2024
|
@dnr thank you! I've incorporated your additions. |
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed? <!-- Describe what has changed in this PR --> Adding a short doc to give a basic overview of the gRPC retry behavior. Note that this could/should also include the task processing retry behavior, but I'm not familiar enough with it to write that right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a short doc to give a basic overview of the gRPC retry behavior.
Note that this could/should also include the task processing retry behavior, but I'm not familiar enough with it to write that right now.