Simplify TaskPoller's WorkflowTaskHandler #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
simplify-task-poller-wft-handler
branch
from
4c7b2c4
to
522f5d2
Compare
stephanos
commented
May 10, 2024
stephanos
force-pushed
the
simplify-task-poller-wft-handler
branch
2 times, most recently
from
d973b97
to
2b440e4
Compare
stephanos
force-pushed
the
simplify-task-poller-wft-handler
branch
from
2b440e4
to
8f39005
Compare
alexshtin
reviewed
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The
TaskPollerwe use in the tests takes aworkflowTaskHandlerwhich has 5 parameters. But all of them come fromPollWorkflowTaskQueueResponseanyway - so might as well use that directly.Why?
Shortens the function's interface.
And most handlers don't use any of the parameters anyway.
How did you test it?
Is nothing but tests.
Potential risks
Documentation
Is hotfix candidate?