Fix a bug in AsyncAllocator memory pools access setting. #67373
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhuilin
reviewed
May 23, 2024
third_party/xla/xla/stream_executor/gpu/gpu_cudamallocasync_allocator.cc
Show resolved
Hide resolved
changhuilin
reviewed
May 23, 2024
third_party/xla/xla/stream_executor/gpu/gpu_cudamallocasync_allocator.cc
Outdated
Show resolved
Hide resolved
changhuilin
added
awaiting PR merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code uses the wrong parameter
ifor cuDeviceCanAccessPeer(), which can cause undefined behavior when(*all_ids_)[i] != platform_device_id, for example, virtual devices are used. Should use(*all_ids_)[i].value()to represent the previous pool id.Also, add a judgment to skip the pool initialization process if it's already initialized previously.