Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

让添加按钮后的 control bar 能够滚动 #4345

Open
wants to merge 2 commits into
base: preview-features
Choose a base branch
from

Conversation

timongh
Copy link
Contributor

@timongh timongh commented Jul 26, 2023

我的笔记本上使用的分辨率不太高,document.body.offsetWidth 只有 1275px。所以在往 control bar 添加按钮后显示会有问题:
1
2
于是我为 control bar 添加了滚动功能

鼠标滚动已经经过测试。但我手上没有平板,没办法测试触摸操作,希望能帮忙测试一下。

也可以考虑,把这个东西独立成一个组件。分辨率不大的用户自行安装;毕竟添加了几个监听事件,还是有些性能成本的。

@the1812
Copy link
Owner

the1812 commented Sep 2, 2023

实测触摸无效, 而且跟其他一些控制栏相关功能 (控制栏背景, 触摸优化之类的) 有冲突, 我觉得这个得单独弄个组件比较好, 明确说明和哪些组件不兼容. (去兼容这些也相当头疼, 而且可能对你来说也派不上用场)

Snipaste_2023-09-02_21-29-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants