Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean web and api routes #107

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Clean web and api routes #107

wants to merge 5 commits into from

Conversation

rafa-acioly
Copy link
Contributor

  • Group routes by controller method
  • Group routes using prefix
  • Organize routes by HTTP verb
  • Remove artisan commands that were being called from the template file (now being called on the routes file)

bobbyiliev
bobbyiliev requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions so far!

The tests seem to be failing, you might have to do a rebase and get the latest changes from main.

@rafa-acioly rafa-acioly force-pushed the clean-routes-grouping-by-prefix branch from 6fb5de9 to f2d7caf Compare November 22, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rafa-acioly @bobbyiliev