Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming lens implementation from @microstates/lens #364

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

taras
Copy link
Member

@taras taras commented May 2, 2019

In the process of building Microstates, @cowboyd wrote our own implementation of lenses. It turned out to be super tiny. I published it as a separate package available as @microstates/lens. This PR removes the local implementation in favour of the external package.

@cowboyd
Copy link
Member

cowboyd commented May 3, 2019

I'd like to make some changes to the lens library first that I've been meaning to make for a really long time. For example, the childAt function isn't really related to the defineChildren function, and so while the former is critical to lenses, the later isn't. Been meaning to break them up for a while.

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage decreased (-0.09%) to 98.752% when pulling 8f70c54 on tm/external-lenses into cd4114b on master.

@taras taras requested a review from cowboyd May 11, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants