[WIP] Copy to view node: added tests

[irynamatveieva]

Pull Request description

Added tests for Copy to view node.

General checklist

• You have reviewed the guidelines document.
• Labels that classify your pull request have been added.
• The milestone is specified and corresponds to fix version.
• Description references specific issue.
• Description contains human-readable scope of changes.
• Description contains brief notes about what needs to be added to the documentation.
• No merge conflicts, commented blocks of code, code formatting issues.
• Changes are backward compatible or upgrade script is provided.
• Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Back-End feature checklist

• Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
• If new dependency was added: the dependency tree is checked for conflicts.
• If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
• If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
• If new yml property was added: make sure a description is added (above or near the property).

[ShvaykaD]

please make Instant.now().minus(1, ChronoUnit.DAYS).toEpochMilli() and Instant.now().plus(1, ChronoUnit.DAYS).toEpochMilli() final fields and reuse them in each test.

[ShvaykaD]

moreover, consider to move creation of entity view to some method and reuse it each test.

[ShvaykaD]

Please see my comments added above.

[ShvaykaD]

Suggested change

	TbMsgType.POST_ATTRIBUTES_REQUEST, DEVICE_ID, new TbMsgMetaData(Map.of("scope", AttributeScope.CLIENT_SCOPE.name())),
	TbMsgType.POST_ATTRIBUTES_REQUEST, DEVICE_ID, new TbMsgMetaData(Map.of(DataConstants.SCOPE, AttributeScope.CLIENT_SCOPE.name())),

[ShvaykaD]

The constructed metadata will not take any effect. See lines 83-84 in the node implementation. However empty metadata will cause the message to fail. Please change the scope in metadata to AttributeScope.SERVER_SCOPE.name() and verify that attributes will be still saved with client scope.

[ShvaykaD]

Suggested change

	mockEntityViewService(entityView);
	mockEntityViewLookup(entityView);

[ShvaykaD]

please add todo to use newMsg with any(TbMsgType)

[ShvaykaD]

please capture the list and verify that it includes the correct attribute inside.

[ShvaykaD]

please capture the list and verify that it includes the correct attribute inside.

[ShvaykaD]

please use verifyNoMoreInteractions(...);

[ShvaykaD]

We will skip the validation if someone mistakenly removes those types from the list of allowed types. Could you please add a test that will ensure that there will be no tellFailure with "Unsupported msg type [" + msgType + "]" exception message if the type is supported?

[ShvaykaD]

Please reuse the existing method of getEntityView() by adding an overload version of it by passing start and endTime.

[ShvaykaD]

This can be moved to constants:

private final long ENTITY_VIEW_START_TS = Instant.now().minus(1, ChronoUnit.DAYS).toEpochMilli();
private final long ENTITY_VIEW_END_TS = Instant.now().plus(1, ChronoUnit.DAYS).toEpochMilli();
private final AttributesEntityView CLIENT_ATTRIBUTES = new AttributesEntityView(List.of("attribute1"), Collections.emptyList(), Collections.emptyList());
private final TelemetryEntityView TELEMETRY_ENTITY_VIEW = new TelemetryEntityView(Collections.emptyList(), CLIENT_ATTRIBUTES);

and this:

private final EntityViewId ENTITY_VIEW_ID = new EntityViewId(UUID.fromString("a2109747-d1f4-475a-baaa-55f5d4897ad8"));

Finally method will be looks like this:

  private EntityView getEntityView() {
      EntityView entityView = new EntityView(ENTITY_VIEW_ID);
      entityView.setStartTimeMs(ENTITY_VIEW_START_TS);
      entityView.setEndTimeMs(ENTITY_VIEW_END_TS);
      entityView.setKeys(TELEMETRY_ENTITY_VIEW);
      return entityView;
  }