Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coap_refactoring_yml #10768

Closed
wants to merge 12 commits into from
Closed

coap_refactoring_yml #10768

wants to merge 12 commits into from

Conversation

nickAS21
Copy link
Contributor

@nickAS21 nickAS21 commented May 12, 2024

Pull Request description

In all *.yml on CE and PE dtls settings should look like this:

coap:
    dtls:
        ...

(without transport)

In TbCoapDtlsSettings itself there should not be transport either, as it is a common structure for different services.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@nickAS21 nickAS21 added the Ignore for release Ignore this PR for release notes label May 12, 2024
@@ -110,6 +110,7 @@ edges.enabled=false
# Transports disabled to speed up the context init. Particular transport will be enabled with @TestPropertySource in respective tests
transport.http.enabled=false
transport.mqtt.enabled=false
coap.enabled=true
transport.coap.enabled=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this one is left?

Copy link
Contributor Author

@nickAS21 nickAS21 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@nickAS21 nickAS21 requested review from ashvayka and YevhenBondarenko and removed request for ViacheslavKlimov May 14, 2024 14:57
@nickAS21 nickAS21 closed this May 19, 2024
@nickAS21 nickAS21 deleted the refactoring_coap_yml branch May 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignore for release Ignore this PR for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants