馃悰 Fix custom response input output schema bug #11517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which should be "serialization" also for custom response models defined in the `responses` option. The same way we do that for the "main" response model on line 475. This fixes issue 1. mentioned in tiangolo#10697
slafs
added a commit
to slafs/fastapi
that referenced
this pull request
May 2, 2024
As documented in https://coverage.readthedocs.io/en/7.5.0/contexts.html#dynamic-contexts While working on tiangolo#11517 I wanted to see which test is best to modify for the fix. One way to easily find this out is to see which line is covered by which test. This PR adds a dynamic context setting and makes them show on the HTML coverage report. The contexts are test function names. NOTE pytest-cov plugin has even better support for pytest test names as coverage contexts, but I think this PR is already an imporovement.
alejsdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue (point 1.) from #10697
Add missing
modeargument when callingcreate_response_fieldfor "custom" response models defined in the
responsesoption of a route.The same way we do that for the "main" response model on line 475.
Otherwise that custom response model schema (if separate i/o models are enabled)
is generated with the "-Input" suffix (instead of
-Output).NOTE this PR doesn't address docs issues that are mentioned in #10697 (point 2.)