fix(android): remove some deprecated classes #14039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
reviewed
May 24, 2024
| public static boolean DEBUG = Config.DEBUG; | ||
| public static boolean RELEASE = !Config.DEBUG; | ||
| public static boolean PROFILE = Config.PROFILE; | ||
| public static boolean LOGD = false; |
There was a problem hiding this comment.
The docs say LOGD is always true. Are we sure we want false here? I have no idea what this is even. The Android docs are completely useless.
Just in case, here's the suggestion to expidite the change:
Suggested change
| public static boolean LOGD = false; | |
| public static boolean LOGD = true; |
There was a problem hiding this comment.
Config.LOGD in the Android Config is true, but here we used Config.DEBUG (which is always false) before. And this is the place where it is set:
TiConfig.DEBUG = TiConfig.LOGD = appProperties.getBool("ti.android.debug", false);
with false as default too. So I would keep it as false.
It is added to every module private static final boolean DBG = TiConfig.LOGD; so in case people use that it should be the same value as before (false) unless you change it with the property.
There was a problem hiding this comment.
Ohhh, that makes sense! Thanks!
cb1kenobi
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just two minor changes that are currently marked as deprecated: