-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os.FindProcess, process.Release #4218
base: dev
Are you sure you want to change the base?
Conversation
b27bafa
to
dd061d8
Compare
91b9c03
to
2f2caa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
01d2922
to
9fa36f7
Compare
To me it looks like these errors are unrelated to the code this patch covers. Any proposal on how to proceed here @aykevl ? |
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
@aykevl any idea what's the problem here? |
seems to be blocked by #4206 |
It's a race that only happens sometimes. I've restarted the test. |
Signed-off-by: leongross <leon.gross@9elements.com>
@aykevl I guess we won the ci race, let's merge this :) |
This implementation of
os.FindProcess
provides minimal functionality while being aligned to the process design pattern oftinygo
.