Fix tips view blank #499
Fix tips view blank #499
Conversation
This reverts commit 11fd868.
# Conflicts: # Easydict/objc/ViewController/Cell/EZTableTipsCell.h # Easydict/objc/ViewController/Cell/EZTableTipsCell.m # Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.h # Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m
AkaShark
requested review from
NeverAgain11,
choykarl,
tisfeng,
CanglongCl,
Jerry23011 and
phlpsong
|
When OCR succeeded, it also displays a tips view 🥲 There are other similar scenes, and tips view also appear strangely, and it doesn't necessarily appear every time. 
|
emm.. OCR I didn't handle more, do you think merging the #478 into this PR. |
|
No, I know, there's no need to change the way tips are displayed when OCR fails at the moment, but it shouldn't be showing the tips view when OCR right now, whether it succeeds or fails. What I mean is that the current way of determining when the tips view appears is inappropriate, it can easily be triggered by mistake, not only for OCR, but even for selecting translation I've encountered this several times, but it doesn't happen every time, it‘s strange. |
Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
# Conflicts: # Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
|
过几天将会发布一个小的修复版本，这个 PR 内容改动有点多，因此暂时先不合。 等发布修复版本后，我再来合并。 |
Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m
Outdated
Show resolved
Hide resolved
|
Please review it again |
Bumps the bundler group with 1 update in the / directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.2.6 to 3.2.8 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.6...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com>
|
I improved some code, please review it and test carefully. |
|
I hava no problems |
close #452