Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(UI): add Confetti effets to about views #535

Merged
merged 19 commits into from May 14, 2024

Conversation

Jerry23011
Copy link
Collaborator

Preview

demo_light.mov
demo_dark.mov

@tisfeng
Copy link
Owner

tisfeng commented May 5, 2024

It's strange, it looks like you've changed the layout?

Now

image

Before

#532 (comment)

image

@Jerry23011
Copy link
Collaborator Author

Yes, I did add a ZStack so that the effect could work. Let me check it

@Jerry23011
Copy link
Collaborator Author

I adjusted the constraints and now it should look the same with the original one.
The upper bound of the title varies by one pixel and the rest are exactly the same

Now

Updated

Before

Original

@tisfeng
Copy link
Owner

tisfeng commented May 5, 2024

ok, looks good.

@tisfeng
Copy link
Owner

tisfeng commented May 5, 2024

I think the layout can be optimized.

image

@Jerry23011
Copy link
Collaborator Author

I think the layout can be optimized.

image

It's now equal, the 1 px difference at the bottom is caused by the shadow effect
image

@tisfeng
Copy link
Owner

tisfeng commented May 6, 2024

I suddenly realized that our setting window can be resized, which can cause some strange coordinate issues.

The size of the setting window is carefully designed by us, and resizing it will affect the UI of the configuration.

I think we should prohibit resizing the window, what do you think?

output.mp4

@Jerry23011
Copy link
Collaborator Author

I suddenly realized that our setting window can be resized, which can cause some strange coordinate issues.

The size of the setting window is carefully designed by us, and resizing it will affect the UI of the configuration.

I think we should prohibit resizing the window, what do you think?

I think that would be a great approach -- most apps from Apple (like what I'm using now, Safari) don't have resizable Settings window.

@AkaShark
Copy link
Collaborator

AkaShark commented May 7, 2024

I think the layout can be optimized.
image

It's now equal, the 1 px difference at the bottom is caused by the shadow effect image

Just out of curiosity, may I ask how the note the drawing is done. Like 117px is auto?

@Jerry23011
Copy link
Collaborator Author

Jerry23011 commented May 7, 2024

Just out of curiosity, may I ask how the note the drawing is done. Like 117px is auto?

Yes it’s auto-calculated by the screenshot app I use: shottr.cc

@AkaShark
Copy link
Collaborator

AkaShark commented May 7, 2024

Just out of curiosity, may I ask how the note the drawing is done. Like 117px is auto?

Yes it’s auto-calculated by the screenshot app I use: shottr.cc

Thank you, it is indeed a useful tool.

@Jerry23011 Jerry23011 changed the title Add Confetti effets to about views perf(UI): add Confetti effets to about views May 7, 2024
@tisfeng tisfeng merged commit 17f346d into tisfeng:dev May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants